[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Acl-devel] [PATCH] Fix minor issues found in getfacl.c

From: Kamil Dudka
Subject: Re: [Acl-devel] [PATCH] Fix minor issues found in getfacl.c
Date: Tue, 08 Sep 2015 14:26:13 +0200
User-agent: KMail/4.14.9 (Linux/4.0.8-304.fc22.x86_64; KDE/4.14.9; x86_64; ; )

On Tuesday 08 September 2015 14:37:56 Jaska Uimonen wrote:
> Hi,
> I was assigned to fix some static analysis issues
> in my company. There we're couple identified in acl.
> These are all in getfacl.c and are quite minor things,
> but here they are anyway... they are mainly concerning
> not freeing things returned from acl_get_identifier.

Looks good to me.  I would personally prefer explicit type conversion when 
freeing id_p instead of changing its declaration:

    acl_free((id_t *) acl_id_p);

... in order to keep the target object write-protected.


> If you find the fixes stupid or bad, please just comment
> and I can try to repair those.
> br,
> Jaska Uimonen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]