[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Acl-devel] [attr PATCH 3/3] Reintroduce symbols that used to be sys
Re: [Acl-devel] [attr PATCH 3/3] Reintroduce symbols that used to be syscall wrappers
Tue, 15 Sep 2015 13:56:54 -0400
On 15 Sep 2015 19:42, Dmitry V. Levin wrote:
> Commit 7921157890d07858d092f4003ca4c6bae9fd2c38 removed symbols
> that were part of ABI.
> Reintroduce these symbols to fix the ABI breakage.
> These backward compatibility symbols just use xattr syscall wrappers
> provided by libc.
it looks like it, but i just want to double check ... these do not provide
symbols that can be linked against right ? if someone uses lsetxattr, and
has -lattr, the linker should ignore that and still use the libc one.
> --- /dev/null
> +++ b/libattr/syscalls.c
> @@ -0,0 +1,67 @@
> +#include <sys/xattr.h>
file needs a comment header w/copyright+license, and a one-line blurb
giving an overview of the file content.
> +int libattr_setxattr (const char *path, const char *name,
drop the space before the "(" ... i know the previous one did it, but
might as well not get it wrong when creating a new file.
Description: Digital signature