Re: [Acl-devel] [PATCH 1/2] xattr.conf: document how libattr itself uses the file

[Mike Frysinger]

On 04 Mar 2019 16:36, Kamil Dudka wrote:
> --- a/xattr.conf
> +++ b/xattr.conf
> @@ -6,6 +6,10 @@
>  # Actions:
>  #   permissions - copy when trying to preserve permissions.
>  #   skip - do not copy.

not really a fan of putting all this information into the config file itself.
it seems we're missing a man page for this and really need to create one.

> +# Note that libattr functions attr_copy_file() and attr_copy_fd() by default
> +# skip all extended attributes that are matched by any of the below patterns,
> +# regardless of the specified action.

"by default" is a little vague.  that's defined here as "using the default check
function when the user calls it with NULL".  the default check function is the
attr_copy_check_permissions helper which ignores all matched ACLs as you say.

are any of these APIs even documented ?  we don't have man pages, and i'm not
familiar with them, so i can't evaluate whether documenting this behavior as
intended is what we want, or whether we should fix the bug.  although the
behavior seems to have been around since the API was first introduced 20 years
ago afaict.
-mike

signature.asc
Description: PGP signature