Re: [AUCTeX-devel] Completion for saveboxes

[Tassilo Horn]

Mads Jensen <address@hidden> writes:

> And the associated ChangeLog entry.  I only found one way to define
> savebox, which is the \newsavebox command.

Then the comment and the docstring are wrong since they also talk about
sbox?

+;; `sbox' is just a short form of `savebox'
+(defvar LaTeX-auto-savebox-regexp-list
+  '(("\\\\newsavebox *{\\([A-Za-z]+\\)}" 1 LaTeX-auto-savebox))
+  "List of regular expressions matching LaTeX saveboxes and
+sboxes only.")


> I hope I got everything correct in the ChangeLog entry this time :-)

Yes, looks good.

> Now, the completion wish for sboxes and counters can be removed from
> the TODO file.

+string. If definition is non-nil, the savebox is added to the
+list of defined saveboxes."
+  (let ((savebox ((completing-read (TeX-argument-prompt optional prompt
+                                                        "Savebox")
+                                   (LaTeX-savebox-list)))))
+    (if (add definition (not (zerop (length savebox))))
          ^^^

There is no `add' function.  I guess you mean `and'.  Really, you should
test your changes before submitting them.

Bye,
Tassilo