[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Thoughts about ax_resip.m4, anyone?

From: Peter Johansson
Subject: Re: Thoughts about ax_resip.m4, anyone?
Date: Thu, 17 Dec 2009 15:36:40 -0500
User-agent: Thunderbird (X11/20090105)

Peter Simons wrote:
How you feel about adding this macro to the archive?

Please encourage contributors to include a serial number in the .m4 file. Also I think hard-coded ACTION-IF_FOUND/ACTION-iF_NOT_FOUND should be encouraged and rather they should be modifiable via the user interface for example as: MACRO([ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND]) with a possible default behavior if the argument is left empty. Below follows some more comments:

                if test -f "$inc/" || test -f "$inc/libresip.a"

Checking for `' is not portable. On Darwin, for example, shared libraries are named *.dylib.


Why using $CFLAGS when testing a test C++ library?

        AC_TRY_LINK([#include <resip/stack/SipStack.hxx>],

AC_TRY_LINK is obsoleted and AC_LINK_IFELSE is to prefer.

            AC_MSG_ERROR([[Could not detect the Resiprocate libraries.]])
Why having any code after exit?


Peter Johansson

svndigest maintainer,
yat maintainer,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]