[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #7074] shared_ptr & weak_ptr from boost

From: Dustin J. Mitchell
Subject: [patch #7074] shared_ptr & weak_ptr from boost
Date: Sat, 30 Jan 2010 19:19:28 +0000
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_4_11; en) AppleWebKit/531.21.8 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10

Follow-up Comment #1, patch #7074 (project autoconf-archive):

Thanks for your submission!  These macros are a nice start, but still include
a number of TODO items embedded in the macros themselves.  I've also added an
assortment of comments below, in no particular order.

You may want to consult the freshly-written "how to contribute"

You can also look at some of the other macros in the archive for licensing
ideas.  As a hint, using the least restrictive license possible will produce
the fewest headaches for potential users.

As contributing.texi indicates, you'll need to allocate these four macros to
four separate files, rather than including two per file.  The macros should
begin with AX_, not AC_, too.

Also, it looks like AC_CXX_HAVE_SHARED_PTR_TEST is used to ensure that the
test is only run once.  This could cause [action-if-*] to be skipped without
warning, if two macros happen to test for this header.  If you feel that
duplicate searching would be a problem, you could use autoconf's support for
caching, but this probably isn't necessary.

It's unusual to put ( .. ) around $1 and $2.  I'm not sure that it would
cause problems, but it's probably best to leave off the parentheses.  If this
leads to a potentially empty clause in a shell conditional, add a ":" (shell
for "no op").


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]