autoconf-archive-maintainers | |
[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: missing quotes in ax_pthread.m4
From: |
Maarten Bosmans |
Subject: |
Re: missing quotes in ax_pthread.m4 |
Date: |
Mon, 1 Aug 2011 14:57:33 +0200 |
2011/8/1 Chun-Chung Chen <address@hidden>:
> Oops, I think you are right! The end quote should move 2-line forward.
> Please revert the previous patch and apply this one. Sorry for the
> confusion.
Then, for extra points in style (just nit-picking here) move the
opening quote to the AC_LANG_PROGRAM line.
Maarten
> With best wishes,
>
> Chun-Chung Chen
>
> On 08/01/2011 06:18 PM, Maarten Bosmans wrote:
>> 2011/8/1 Chun-Chung Chen <address@hidden>:
>>> Hi,
>>>
>>> I just spotted some missing quotes in "ax_pthread.m4", which triggered a
>>> bunch warnings in AC_LANG_CONFTEST of autoconf-2.68. Please see the
>>> attached patch.
>> Why are you quoting all three arguments of AC_LINK_IFELSE together?
>> That doesn't seem right.
>>
>> Maarten
>>
>>> With best wishes,
>>>
>>> Chun-Chung
>>>
>
>