[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #7985] Feature additions to AX_CXX_COMPILE_STDCXX_11 macro

From: Zack Weinberg
Subject: [patch #7985] Feature additions to AX_CXX_COMPILE_STDCXX_11 macro
Date: Fri, 29 Mar 2013 17:52:33 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 Iceweasel/18.0.1

Follow-up Comment #2, patch #7985 (project autoconf-archive):

There appears to be one outright bug: ax_cv_cxx_compile_cxx11_required is
initialized to either 'true' or 'false', but is later tested against 'no'. 
(Use of 'true' and 'false' in this context is contra standard Autoconf
practice, it should be 'yes' and 'no'.)  If 'true' is replaced with 'yes' and
'false' with 'no', then the sense of the conditional is also backward.

I also have a few minor criticisms:

* When the macro is used in "C++11 support is mandatory" mode, it should not
set the shell variable HAVE_CXX11 nor should it make any AC_SUBST, AC_DEFINE,
or AM_CONDITIONAL definitions.

* The embedded use of AM_CONDITIONAL introduces an invisible dependency on
automake; this should probably be removed altogether.

* ax_cv_cxx_compile_cxx11_required is not the result of a test and should not
have a _cv_ name.

* Use of 'true'/'false' to toggle mandatory/optional means that
will be less readable than it could be.  Why not 'mandatory' or 'optional'

* `dnl`s were removed in a few places, perhaps because they appeared to be
unnecessary.  Their purpose was to suppress extra blank lines in the generated
configure script.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]