[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #8638] Remove non-ASCII Characters-in Comments

From: Moritz Klammler
Subject: [patch #8638] Remove non-ASCII Characters-in Comments
Date: Sat, 04 Apr 2015 02:30:00 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Iceweasel/36.0.4


                 Summary: Remove non-ASCII Characters-in Comments
                 Project: GNU Autoconf Archive
            Submitted by: moritz_klammler
            Submitted on: Sat 04 Apr 2015 04:29:58 AM CEST
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any



The files `m4/ax_compiler_flags.m4`, `m4/ax_compiler_flags_cflags.m4`,
`m4/ax_compiler_flags_cxxflags.m4` and `m4/ax_compiler_flags_ldflags.m4`
contained non-ASCII characters that caused (at least if using Python 3) the
`` script that is run as part of `make maintainer-all` to fail.

Since all offensive characters were apostrophes in comments, I simply replaced
them with ASCII 39 characters.  This fixes the immediate issue.  I assume that
ASCII encoding was deliberately chosen for maximum portability.  Otherwise, it
might be preferred to modify the Python script to use UTF-8 encoding thus
allowing such characters.

I have also attached a little Python script that can be used to check whether
a file contains non-ASCII characters.  I've run it over all `m4/*.m4` files
and it did not report any other issues.


File Attachments:

Date: Sat 04 Apr 2015 04:29:58 AM CEST  Name:
0001-Removed-non-ASCII-characters-in-comments.patch  Size: 5kB   By:

Date: Sat 04 Apr 2015 04:29:58 AM CEST  Name:  Size: 633B  
By: moritz_klammler



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]