[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Optimization for install-sh

From: Lars J. Aas
Subject: Re: Optimization for install-sh
Date: Fri, 10 Nov 2000 14:09:58 +0100
User-agent: Mutt/1.2.5i

On Thu, Nov 09, 2000 at 03:32:31PM -0500, Pavel Roskin wrote:
: Hello, Alexandre!
: > > : +       if [ x"$chmodcmd" != x ]; then $doit $chmodcmd $dsttmp; else 
:;fi &&
: > 
: > > Shouldn't all these be rewritten as "if test ...;" instead?
: Better portability of "test" compared to "[" is probably one of the "urban
: legends".

I thought we liked urban legends...

Anyways, I say we rewrite it for consistency with the rest of the Autoconf
scripts.  We don't want [] tests trickling back into autoconf because of the
m4 quotes.

: > { test "x$...cmd" = x || $doit $...cmd $arg ; }
: That's not quite the same. If the command (e.g. strip) is not defined we
: don't want to ignore the consequtive commands. But if it fails we do want
: to bail out, since running "chmod 4755 foo" after failed "chown r00t foo"
: would be _very_ bad.

Anyways, there were a whole sh*tload of redundant else clauses in that script
that we could remove.  If not for more readability; think of all the diskspace
we can save ;)

  Lars J

reply via email to

[Prev in Thread] Current Thread [Next in Thread]