[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 18-bugs.patch

From: Akim Demaille
Subject: Re: 18-bugs.patch
Date: 13 Nov 2000 10:32:17 +0100
User-agent: Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.1 (Channel Islands)

| > Not a good idea if acversion.m4 is read-only but the directory is not.
| Yep.  Besides, the proposed change won't generate acversion.m4 in the
| srcdir.  Is that intended.

Nope, thanks for spotting this.

| Another issue is that, if `sed' doesn't run to completion, for
| whatever reason, you end up with an acversion.m4 whose timestamps is
| newer than its dependencies and that won't be updated on the next
| `make'.  That's the reason for using the temporary file.

Yep, I know, but in this case, it looked overkill to me.  But I agree,
I must have had some slight absence yesterday, it's a stupid change.

| I also recommend to use mv, and only fallback to cp and rm if mv
| fails.
| >> +* Grave bugs
| I'd say `serious' instead.  Even though grave is a synonym with it,
| ``grave bugs'' admits other readings that sound odd, or even funny.
| Or maybe you really meant insects that inhabit coffins? :-)

:) :) :)

| >> +** : ${foo=$val}
| >> +There are problems on Ultrix and I don't recall which architecture.
| There's also the problem of having cached variables containing the `}'
| character, that breaks with Solaris' /bin/sh.  I don't know whether
| this is a ``grave bug'', though :-)

About this bug, does it happen whenever there is a non balanced `}',
or as soon as a `}' is found?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]