Re: 32-autotest-for-case.patch

[Alexandre Oliva]

On Nov 20, 2000, DEMAILLE Akim <address@hidden> wrote:

>       Transform Autotest so that instead of

>       ...
>       if run test 42
>       prologue tests
>       check 42 a
>       check 42 b
>       epilogue tests
>       fi

>       if run test 43
>       prologue tests
>       check 43 a
>       epilogue tests
>       fi
>       ...

>       it builds

>       for test in $tests
>       do
>       case $test in

>       ...

>       42)
>       prologue tests
>       check 42 a
>       check 42 b
>       epilogue tests
>       ;;
>       43)
>       prologue tests
>       check 43
>       epilogue tests
>       ;;
>       ...

>       esac
>       done

>       As a known side effect, currently any code outside
>       AT_SETUP/AT_CLEANUP is discarded.

>       * acgeneral.m4 (_m4_divert(KILL)): Move to...
>       * m4sugar.m4: here.
>       * tests/atgeneral.m4 (AT_INIT): Use m4_divert_push/pop instead of
>       m4_divert.
>       Put all the tests inside a for;case.
>       Define TESTS.
>       (AT_SETUP, AT_CLEANUP): Open/close each case.

Ok, except for the ChangeLog entry.  It's too short.  Please expand. :-)

Seriously, I don't think such a long ChangeLog entry is appropriate.
Something like `Generate a case statement instead of a sequence of ifs
to determine which tests to run.' would be more appropriate, IMO.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  address@hidden, redhat.com}
CS PhD student at IC-Unicamp        address@hidden, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me