Re: 96-testsuite-log.patch

[Pavel Roskin]

On Sat, 13 Jan 2001, Akim Demaille wrote:

> Index: ChangeLog
> from  Akim Demaille  <address@hidden>
>       * tests/atgeneral.m4 (AT_INIT): When the suite failed, complain
>       before creating the debug scripts.
>       Create a log file.
>       When ignoring a test, display a reassuring `ok' for stressed
>       users, and say `skipped' instead.

Your vacation in New York was very useful for you, Akim :-)

>       Simply run `testsuite' with the failed tests instead of running
>       the debug scripts, this avoids having zillions of banners `Testing
>       Blabla 2.13' (another means to avoid these banners is to have the
>       test suite succeed :-).

Not quite clear what you mean. I think, the testsuite should not be
verbose unless "-v" was given, even if it fails. For the failed tests, the
debug scripts with "-v" should be created, and the testsuite should be
rerun for those tests with another option, which would write the verbose
output to the log (or separate logs for every failed test).

I guess your patch is a step in that direction, but I'm not sure.

> -# STDOUT and STDERR can be the special value `ignore', in which case
> +# STDOUT and STDERR can be the special value `skip', in which case

This is wrong. If you want to change it, you need a separate patch that
changes all those "ignore" to "skip", also in AT_CHECK below.

Ok to apply, except the last comment change.

Regards,
Pavel Roskin