autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 94-as-literal-if.patch


From: Akim Demaille
Subject: Re: 94-as-literal-if.patch
Date: 15 Jan 2001 08:20:20 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Crater Lake)

| > -                [$4])dnl
| > +      [$4])[]dnl
| 
| I don't think the square brackets before dnl make any difference. 

I do :)  I must say I didn't really paid attention whether they were
_needed_ there, but they might be.

| But they
| make the code harder to read. 

Agreed.

| Unlike things like AC_MSG_RESULT([no]), that
| can eventually grow to AC_MSG_RESULT([no, don't even ask]) I see no way
| how this expression can be changed so that the brackets become
| significant. No sane person will expect e.g. "fidnl" to work.

I agree, but the day we change an old macro having it end with
letters, we might be happy to have protected it.  BUt then, the macro
itself could end with `[]', agreed.  No strong opinion.  Feel free to
strip them.

| > -m4_ifvaln([$3],[$3])dnl])
| > +m4_ifvaln([$3],[$3])dnl])[]dnl
| 
| See above.

This is indeed a typical example where [] is useless, thanks.

| > +# This is an *approximation*: for instance EXPRESSION = `\$' is
| > +# definitely a literal, but will not be recognized as so.
| 
| as such.

Arg, thanks again!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]