Re: 10-forbidden-tokens-in-comments.patch

[Akim Demaille]

>>>>> "Alexandre" == Alexandre Oliva <address@hidden> writes:

Alexandre> How about an additional -W flag that would enable searching
Alexandre> for macro names within comments?  It would be disabled by
Alexandre> default, but we'd use it in our own testsuite.

Yep, that's proposal number 2 :)  Well, as far as the test suite is
concerned, it would not have triggered the problem, which is also
related to under quotation.  That's why I would have suggested
enabling by default.  But sure, as long as user can turn on maximum
safety on, I'm OK.

While we are at it, forbidden tokens not in comments are errors or
warnings?  The status has never been clear: they look like an error,
i.e., the message and $?, but behave like a warning, i.e., the output
is left.

I'd be OK with making this a warning, at least that's much more
conventional and understandable.  And WARNINGS=error restores the old
behavior.

-W forbidden-tokens
-W forbidden-tokens-in-comments

?