Re: 17-proto-autoscan-check.patch

[Pavel Roskin]

> | > ~/src/bison % ../ace/autoscan -A ../ace
> | > Name "main::line" used only once: possible typo at ../ace/autoscan line 
> 465.
> | > Name "main::args" used only once: possible typo at ../ace/autoscan line 
> 465.
> |
> | What version of perl are you using?
>
> What you are reading is the result of the patch I submitted for
> autoscan, to have it *check* the completeness of existing configure.ac
> in addition of generating configure.scan.

It's strange that you are trying to make autoscan responsible for two very
different tasks.

I can understand checking configure.scan by autoscan, but checking
configure.ac is something very different. Even if autoscan has everything
for that task (which I doubt) I would prefer to have a separate executable
for checking configure.ac, say, "autocheck".

Autoscan could feed it's output to autocheck. Maybe even autoconf could
optionally check configure.ac before processing.

But integrating autocheck and autoscan doen't seem to be justified.

> | >  # Reference these variables to pacify perl -w.
> | > -undef %identifiers_macros;
> | > -undef %makevars_macros;
> | > -undef %programs_macros;
> | > +%identifiers_macros = ();
> | > +%makevars_macros = ();
> | > +%programs_macros = ();
> | > +%needed_macros = ();
> |
> | I'm surprised. Your Perl must be either very old or very new. I thought
> | "undef" is perfectly valid and safe here.
>
> Err, to be honest I just did this because that's what I saw in
> automake, and I wanted to be close from Tom's style.

Automake used to support Perl 4. The CVS version doesn't claim to support
it, but the style used in Automake is still quite old-fasioned.

Autoscan already used "Getopt::Long", so it makes no sence to play in
portability.

By using the modern features, such as "use strict" and "my" you can write
much better code. The patch follows.

Regards,
Pavel Roskin