[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Tim Van Holder
Date: Tue, 18 Sep 2001 11:14:27 +0200

> Don't you need an AC_REQUIRE([AC_PROG_LN_S])?

Yup - I originally checked against $as_ln_s, but remembered
Akim's "Don't use internal variables, Luke".  So I changed it
to $LN_S, but forgot that was only substituted if AC_PROG_LN_S
is invoked (does that make sense, btw?  we always compute it, so
why don't we substitute it too?)

> Why do you mention the file 'conftsym.exe'?  That looks like a typo.

It is indeed.

> How about if you simplify the code with something like this?
> rm -f conftest.sym conftest.file
> if test "$LN_S" = "ln -s" && ln -s conftest.file conftest.sym; then

Much better, indeed.

> Also you need a ChangeLog entry describing this change only.

But of course:

2001-09-16  Tim Van Holder  <address@hidden>

        * lib/autoconf/functions.m4:
        (AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK): Only run the test if
        we previously found 'ln -s' to work.

> > I also noticed that _AC_FUNC_FORK contains an 8-bit character (ΓΌ/u:)
> > in a C comment.  Are there still compilers/preprocessors around that
> > might choke on that (I doubt it, but I thought I'd check)?
> Yes, possibly, in some locales, e.g. shift-JIS.  It's better to remove
> stuff like that.

I'll remove that as well.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]