[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Site Macro Directory

From: Akim Demaille
Subject: Re: Site Macro Directory
Date: 11 Jun 2002 11:35:24 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)

| On Fri Jun 07 12:01 2002 +0200, Akim Demaille wrote:
| > It should be ok.  But I still have a few comments about the patch
| > itself:
| [...]
| I've attached a new version of the patch that should fix these
| problems.

Thanks, it looks good to me.  Except that sentences should be
capitalized in the ChangeLog.

| > There is one thing I don't like too much though: I have paid attention
| > to make autoconf == automake -l autoconf.  This is no longer the case
| > with your change.  Could you try to move the -I stuff into
| > autom4te.cfg?
| I assume you mean "autoconf == autom4te -l autoconf", not "autoconf ==
| automake -l autoconf"...?

Correct, sorry.

| I'll take a closer look at this and get back to you.

Great.  It matters a lot.  Pay espcially attention to this: you did
equip properly autom4te with -i, but what about autoreconf,
autoupdate, autoheader, autoscan and autoconf?  As it is, I am very
surprised that the test suite passes.  The whole point is that the
test suite must use the non installed files.  With your patches, it
does not, since it still uses --include instead of --prepend-include.

In other words, as is, your patch breaks any non installed Autoconf :(

| > And most importantly: did you run the testsuite?
| I have now. ;)

Well, not under severe conditions :(

| > If you ran the testsuite, I propose that we go in two steps: we apply
| > your patch as is (but the few minor points above), and then we work
| > are making autoconf == automake -l autoconf again.
| Sounds good to me.

Great, we'll do that.

Please, the --prepend-include is an absolute necessity for all the
tools.  Plus the test wrappers that must be updated to use
--prepend-include instead of --include.  I cannot install your patch
currently, as it will certainly break someone's CVS Autoconf.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]