[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch to fix bug in VPATH in generated Makefile

From: Alexandre Duret-Lutz
Subject: Re: Patch to fix bug in VPATH in generated Makefile
Date: Wed, 23 Apr 2003 09:45:19 +0200
User-agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.2 (gnu/linux)

Hi Mo,

>>> "Mo" == Mo DeJong <address@hidden> writes:


 Mo> 2003-04-22  Mo DeJong <address@hidden>

 Mo> * lib/autoconf/status.m4 (AC_OUTPUT): When srcdir is "."
 Mo> and the VPATH in the Makefile is being modified, make
 Mo> sure the trailing / is removed since the current
 Mo> code will break perfectly good Makefiles. Also,
 Mo> make the subst global so that multiple srcdir
 Mo> values will get substituted.

 Mo> A line like:
 Mo> VPATH = $(srcdir)/generic:$(srcdir)/unix:$(srcdir)/win
 Mo> Should produce a Makefile like:
 Mo> VPATH = generic:unix:win

 Mo> But the buggy code instead produced:
 Mo> VPATH = /generic:$(srcdir)/unix:$(srcdir)/win

The comment in the code is probably confusing (and ought to be
completed with your examples, IMHO) but the point is that
./configure should *entirely* remove lines like

  VPATH = $(srcdir)

when srcdir=".".  This is the most common VPATH setting in
autoconfiscated projects.  Is this behavior preserved by your
patch?  (I don't think so, but maybe I've overlooked something.)

Alexandre Duret-Lutz

reply via email to

[Prev in Thread] Current Thread [Next in Thread]