[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 3-gary-new-AC_PROG_SED.patch

From: Gary V . Vaughan
Subject: Re: 3-gary-new-AC_PROG_SED.patch
Date: Thu, 22 Jan 2004 23:20:55 +0000

Hi Paul!

On Thursday, January 22, 2004, at 07:07  pm, Paul Eggert wrote:
Wouldn't it be simpler just to invoke
_AS_PATH_WALK([$PATH /usr/xpg4/bin]
and omit the two for loops?

Good call.  Yes, it would.

Local variables should start with ac_, not _ (e.g., "ac_sed" not "_sed").


+    echo >>

I vaguely recall that plain "echo" outputs nothing on some hosts.
"echo ''" is safer.


+    $_sed -e 's/a$//' < >conftest.out || break
+    cmp -s conftest.out || break

Is cmp -s portable?  It might be more portable to use plain "cmp"
and redirect output to /dev/null.

I dunno, but it can't hurt to err on the side of caution.

+    # 10000 chars as input seems more than enough
+    test $_count -gt 10 && break

This comment is confusing as the "10" and the "10000" seem linked,
but they're not really.

Well they are, it just isn't obvious how :-)

Could you please resubmit after addressing the above issues?  Thanks.


Gary V. Vaughan      ())_.  address@hidden,}
Research Scientist   ( '/
GNU Hacker           / )=
Technical Author   `(_~)_

Attachment: 3bis-gary-new-AC_PROG_SED.patch
Description: Binary data

Attachment: PGP.sig
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]