[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Gary V . Vaughan
Thu, 22 Jan 2004 23:20:55 +0000
On Thursday, January 22, 2004, at 07:07 pm, Paul Eggert wrote:
Wouldn't it be simpler just to invoke
and omit the two for loops?
Good call. Yes, it would.
Local variables should start with ac_, not _ (e.g., "ac_sed" not
+ echo >>conftest.nl
I vaguely recall that plain "echo" outputs nothing on some hosts.
"echo ''" is safer.
+ $_sed -e 's/a$//' < conftest.nl >conftest.out || break
+ cmp -s conftest.out conftest.nl || break
Is cmp -s portable? It might be more portable to use plain "cmp"
and redirect output to /dev/null.
I dunno, but it can't hurt to err on the side of caution.
+ # 10000 chars as input seems more than enough
+ test $_count -gt 10 && break
This comment is confusing as the "10" and the "10000" seem linked,
but they're not really.
Well they are, it just isn't obvious how :-)
Could you please resubmit after addressing the above issues? Thanks.
Gary V. Vaughan ())_. address@hidden,gnu.org}
Research Scientist ( '/ http://www.oranda.demon.co.uk
GNU Hacker / )= http://www.gnu.org/software/libtool
Technical Author `(_~)_ http://sources.redhat.com/autobook
Description: Binary data
Description: This is a digitally signed message part