[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: _AC_FEATURE_CHECK_LENGTH bug (Was: Re: 4-gary-AC_PROG_GREP.patch)

From: Albert Chin
Subject: Re: _AC_FEATURE_CHECK_LENGTH bug (Was: Re: 4-gary-AC_PROG_GREP.patch)
Date: Tue, 20 Apr 2004 16:51:53 -0500
User-agent: Mutt/1.5.6i

On Tue, Apr 20, 2004 at 10:06:01PM +0100, Gary V.Vaughan wrote:
> Hash: SHA1
> Hi Albert,
> On 20 Apr 2004, at 21:08, Albert Chin wrote:
> >On Tue, Apr 20, 2004 at 06:23:40PM +0100, Gary V. Vaughan wrote:
> >>Applied the relevant part of Alberts original patch.
> >
> >What about the rest of the patch?
> It hasn't arrived in the mailman archives yet, but a few minutes after I
> posted the above, I posted this:

Huh? I posted a link to the patch in the mailman archive:

> Gary V. Vaughan wrote:
> >Alexandre Duret-Lutz wrote:
> >| My impressions is that your change will cause the test to exit
> >| as soon as a working tool is found, although the intent was to
> >| try many names of the tool and return the better one.  The
> >| original `break 2' looks correct to me: it exits the tests for
> >| the current name of the tool and continues with other names.
> >
> >Agreed.  I've applied the typo fix part of the patch however.
> >
> >The encapsulation within that macro set isn't ideal, but the break 2 is
> >an optimisation.

The 'break 2' assumes too much. The changelog entry reasons why.

Am I missing something? Should we not break out early so we can test
all values in $2?

albert chin (address@hidden)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]