Re: FYI: 7-gary-_AC_FEATURE_CHECK_LENGTH-break-3.patch

[Gary V. Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Eggert wrote:
| "Gary V. Vaughan" <address@hidden> writes:
|
|
|>   * lib/autoconf/programs.m4 (_AC_FEATURE_CHECK_LENGTH): Break out
|>   of the _AS_PATH_WALK loop too if GNU flavor is found.
|
|
| Thanks.  What about the other three instances of 'break 2' in
| lib/autoconf/programs.m4, one in AC_CHECK_PROG and the other in
| AC_PATH_PROG?  They look fishy, as they break into one of the loops
| inside AS_PATH_WALK.  Is that really the intent?  If so, they should
| be commented, surely.


I only see two remaining instances of `break 2' in programs.m4, and
_AS_PATH_WALK adds only 1 nesting level.

AFAICT AC_CHECK_PROG correctly breaks out of its ac_exec_ext loop and the
_AS_PATH_WALK loop when a suitable ac_cv_prog_$1 is found.  AC_PATH_PROG
is much the same.

_AC_PATH_PROG_FEATURE_CHECK uses a slightly different pattern because in
addition to the _AS_PATH_WALK and ac_exec_ext loops, there is an additional
ac_prog loop around the list of potential program names, so it requires a
`break 3'.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAh4IWFRMICSmD1gYRAre4AKDKyAY0afNIyIHJ4KZyP+5hW4nGRQCfYqG0
P4WTNgncAaxY0tRGoJ+plu0=
=4lkp
-----END PGP SIGNATURE-----