Re: FYI: autoheader & --force

[Ralf Corsepius]

Hi Akim,

some nit-picking. 

IMO, some of your Copyright changes should be modified:

On Thu, 2005-01-27 at 10:30 +0100, Akim Demaille wrote:

> Index: doc/make-stds.texi
> ===================================================================
> RCS file: /cvsroot/autoconf/autoconf/doc/make-stds.texi,v
> retrieving revision 1.32
> diff -u -u -r1.32 make-stds.texi
> --- doc/make-stds.texi 3 Dec 2002 07:58:02 -0000 1.32
> +++ doc/make-stds.texi 27 Jan 2005 09:31:39 -0000
> @@ -8,8 +8,8 @@
>  @cindex conventions for makefiles
>  @cindex standards for makefiles
>  
> address@hidden Copyright 1992, 1993, 1994, 1995, 1996, 1997, 1998, 2000, 2001 
> Free
> address@hidden Software Foundation, Inc.
> address@hidden Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 2000, 
> 2001,
> address@hidden 2004, 2005 Free @c Software Foundation, Inc.
We have 2005. As your diffs clearly show, there had been no changes in
2004.

Though you might have written some of your patches, I don't think it is
legally correct to update the Copyright notice to 2004.

> Index: lib/Autom4te/Channels.pm
> ===================================================================
> RCS file: /cvsroot/autoconf/autoconf/lib/Autom4te/Channels.pm,v
> retrieving revision 1.2
> diff -u -u -r1.2 Channels.pm
> --- lib/Autom4te/Channels.pm 12 Sep 2003 08:40:36 -0000 1.2
> +++ lib/Autom4te/Channels.pm 27 Jan 2005 09:31:39 -0000
> @@ -1,4 +1,4 @@
> -# Copyright (C) 2002 Free Software Foundation, Inc.
> +# Copyright (C) 2002, 2004 Free Software Foundation, Inc.
.. and here ...
 
> Index: lib/Autom4te/FileUtils.pm
> ===================================================================
> RCS file: /cvsroot/autoconf/autoconf/lib/Autom4te/FileUtils.pm,v
> retrieving revision 1.6
> diff -u -u -r1.6 FileUtils.pm
> --- lib/Autom4te/FileUtils.pm 20 Aug 2004 19:58:07 -0000 1.6
> +++ lib/Autom4te/FileUtils.pm 27 Jan 2005 09:31:39 -0000
> @@ -1,4 +1,4 @@
> -# Copyright (C) 2003  Free Software Foundation, Inc.
> +# Copyright (C) 2003, 2004, 2005  Free Software Foundation, Inc.
.. and here ...

> Index: lib/Autom4te/XFile.pm
> ===================================================================
> RCS file: /cvsroot/autoconf/autoconf/lib/Autom4te/XFile.pm,v
> retrieving revision 1.11
> diff -u -u -r1.11 XFile.pm
> --- lib/Autom4te/XFile.pm 9 Oct 2003 20:23:54 -0000 1.11
> +++ lib/Autom4te/XFile.pm 27 Jan 2005 09:31:39 -0000
> @@ -1,4 +1,4 @@
> -# Copyright (C) 2001, 2003 Free Software Foundation, Inc.
> +# Copyright (C) 2001, 2003, 2004 Free Software Foundation, Inc.
.. and here ...


Ralf