[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Simplify sed processing of CONFIG_HEADERS

From: Stepan Kasal
Subject: Simplify sed processing of CONFIG_HEADERS
Date: Wed, 18 May 2005 17:14:50 +0200
User-agent: Mutt/1.4.1i

  I did a cleanup of the headers section of status.m4.

-- The code is more correct in a corner case: if you issue several
AC_DEFINEs, the last one is used, as a comment suggested.

-- I use ac_max_sed_lines, not ac_max_here_lines, as an old comment

-- config.status is probably quicker now: I use one s/// command per
each define, which means that 97 defines are processed by one sed run.
I believe that the fact that less filtering rounds are needed overweights
any optimization inside the sed script.  And even if I'm wrong, I don't
mind it, more projects have only one config header.

-- The generated configure script and config.status script are probably
a bit shorter now.

-- The code is shorter, and more readable, I hope.

Is the patch OK?
Can it be commited?

Have a nice day,
        Stepan Kasal

Attachment: autoconf-20050518-config-headers.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]