autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: _AC_COMPILER_EXEEXT cleanup


From: Ralf Wildenhues
Subject: Re: _AC_COMPILER_EXEEXT cleanup
Date: Thu, 8 Sep 2005 09:25:02 +0200
User-agent: Mutt/1.4.1i

Hi Stepan, Paul,

* Paul Eggert wrote on Thu, Sep 08, 2005 at 01:09:43AM CEST:
> Stepan Kasal <address@hidden> writes:
> > 2005-08-31  Stepan Kasal  <address@hidden>
> >
> >     * lib/autoconf/lang.m4 (_AC_COMPILER_EXEEXT_DEFAULT): Don't try to
> >       detect exeext, it will be done by _AC_COMPILER_EXEEXT_O; just set
> >       ac_file top the name of the default output file.  Move the definition
> >       of ac_files and the initial `rm' of the candidate files...
> >     (_AC_COMPILER_EXEEXT): ... here and simplify them.  Moreover, use
> >       the same list in subsequent `rm' calls, and for the temporary
> >       redefinition of ac_clean_files.
> >     (_AC_COMPILER_EXEEXT_O): Don't export ac_cv_exeext, it's not needed (or
> >       no longer needed) by libtool.  Make it a cache check.
> >     (_AC_COMPILER_EXEEXT_CROSS): Remove the comment, it was obviously
> >       copied here by mistake.
> 
> I didn't see any problem with this, and nobody else has commented on it.

I have to admit that the patch was too complicated for me to check by
visual inspection only, and I haven't gotten around to testing it.
(It might have been a good idea to inspect the suspects that use the
darker corners of these macros, probably gcc or some cross compiling
setup.)

> Please commit.

Guess I (or whoever) will just speak up when I find something broken. :)

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]