[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tru64/OSF: BIN_SH revisited

From: Stepan Kasal
Subject: Re: Tru64/OSF: BIN_SH revisited
Date: Fri, 17 Mar 2006 16:27:09 +0100
User-agent: Mutt/1.4.1i


> 0a) Revert the change to set BIN_SH in Autoconf, [...]

IMHO this is a very good idea.

First, BIN_SH is set in macro AS_BOURNE_COMPATIBLE, but it doesn't belong
there: this macro contains things like "set -o posix", which
 i) have an immediate effect inside the current instance
 ii) are not inhereted in subsequent calls to the shell

(Because of (ii), AS_BOURNE_COMPATIBLE is called from _AS_RUN.)

Second, if this change

> 0b) Additionally, prepend /usr/bin/posix/ to the path walk of

make things work on OSF, then the BIN_SH assignment becomes redundant
cruft, right?

We shall remove it now, before is is conserved by a release.

(If the problem re-appears when 2.60 will be widely used, we can then
add BIN_SH to the right place (the "detect better shell" stuff), and
with a comment explaining the situation where it was necessary.)

Does this sound convincing?

Moreover, I think that the line
        DUALCASE=1; export DUALCASE
doesn't belong to AS_BOURNE_COMPATIBLE either, the reason is the same
as above; I think it shall go to AS_SHELL_SANITIZE.

These two changes would make the following patch; OK to commit?

Have a nice day,

Attachment: autoconf-20060317-sanitize.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]