autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Autotest: point to log more prominently


From: Ralf Wildenhues
Subject: Re: Autotest: point to log more prominently
Date: Mon, 3 Apr 2006 06:47:07 +0200
User-agent: Mutt/1.5.9i

Hi Noah,

* Noah Misch wrote on Mon, Apr 03, 2006 at 12:34:06AM CEST:
> On Mon, Oct 10, 2005 at 06:35:57PM +0200, Ralf Wildenhues wrote:
> >         * lib/autotest/general.m4 (AT_INIT): Add `at_testdir' to pointer
> >         to log, point to testsuite output tree.
> 
> This is a valuable change.

Thanks for the review!

> > -  echo "Please send \`$as_me.log' and all information you think might 
> > help:"
> > +  echo "Please send \`${at_testdir}/$as_me.log' and all information you 
> > think might help:"
> 
> Some code in lib/autotest/general.m4 contemplates the possibility that
> `atconfig' does not exist, a so-called standalone test suite.  In this case,
> $at_testdir will be empty or unset, and the output will look funny.

Good catch!

> You could use $at_suite_log (`pwd`/$as_me.log), as an alternative.

That's a bit ugly, as long absolute paths are not uncommon and will lead
to long lines in the output.  I've installed the following instead, to
avoid the stray `/' if at_testdir is unset.

Cheers,
Ralf

        * lib/autotest/general.m4 (AT_INIT): Add `at_testdir' to pointer
        to log, point to testsuite output tree.

Index: lib/autotest/general.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autotest/general.m4,v
retrieving revision 1.201
diff -u -r1.201 general.m4
--- lib/autotest/general.m4     1 Apr 2006 22:53:04 -0000       1.201
+++ lib/autotest/general.m4     3 Apr 2006 04:43:24 -0000
@@ -976,7 +976,7 @@
   AS_BOX([$as_me.log was created.])
 
   echo
-  echo "Please send \`$as_me.log' and all information you think might help:"
+  echo "Please send \`${at_testdir+${at_testdir}/}$as_me.log' and all 
information you think might help:"
   echo
   echo "   To: <AT_PACKAGE_BUGREPORT>"
   echo "   Subject: @<:@AT_PACKAGE_STRING@:>@ $as_me:dnl
@@ -986,7 +986,8 @@
   if test $at_debug_p = false; then
     echo
     echo 'You may investigate any problem if you feel able to do so, in which'
-    echo 'case the test suite provides a good starting point.'
+    echo 'case the test suite provides a good starting point.  Its output may'
+    echo "be found below \`${at_testdir+${at_testdir}/}$as_me.dir'."
     echo
   fi
     exit 1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]