[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: maintainer checks
From: |
Eric Blake |
Subject: |
Re: maintainer checks |
Date: |
Thu, 06 Apr 2006 00:15:41 +0000 |
Hi Ralf,
>
> I have applied the two attached patches.
> * TODO, config/Makefile.am, lib/freeze.mk, lib/autoconf/c.m4,
> lib/autoconf/specific.m4, lib/autoconf/status.m4,
> lib/autoconf/types.m4, lib/autotest/general.m4,
> tests/mktests.sh, tests/torture.at: White space cleanup:
> remove some SPACE before TAB, or add quoting ('' or @&t@).
Thanks for the cleanup. However, I wonder if you got everything
right - I did this:
cvs diff -Bw -D 'Apr 5 11am' -D 'Apr 5 3 pm'
to see just the quoting changes in your changset, and noticed
the following:
> +++ lib/autoconf/status.m4 5 Apr 2006 20:55:14 -0000 1.91
> @@ -606,14 +606,14 @@ uniq confdefs.h |
> sed -n '
> t rset
> :rset
> - s/^[ ]*#[ ]*define[ ][ ]*//
> + s/^[ '' ]*#[ '' ]*define[ '' ][ ]*//
only 3 of the four brackets were re-quoted here...
@@ -641,8 +641,8 @@ do
dnl Quote, for the `[ ]' and `define'.
echo [' # First, check the format of the line:
cat >"$tmp/defines.sed" <<CEOF
-/^[ ]*#[ ]*undef[ ][ ]*$ac_word_regexp[ ]*$/b def
-/^[ ]*#[ ]*define[ ][ ]*$ac_word_regexp[( ]/b def
+/^[ ]*#[ ]*undef[ ][ ]*$ac_word_regexp[ @&t@ ]*$/b
def
+/^[ ]*#[ ]*define[ ][ ]*$ac_word_regexp[( @&t@ ]/b def
and only 1 of the 5 brackets here was re-quoted.
On the other hand, I figured out why - those are tab-spaces, instead
of space-tabs. Do we want a consistent when doing a regex for
both characters, where order doesn't matter; which is different than
doing a literal like IFS where order does matter?
--
Eric Blake