Re: maintainer checks

[Ralf Wildenhues]

Hi Paul,

* Paul Eggert wrote on Wed, Apr 05, 2006 at 02:37:28AM CEST:
> Ralf Wildenhues <address@hidden> writes:
> 
> > -   @grep -nE '\<free \(\(' $(srcdir)/{lib,src}/*.[chly] &&         \
> > +   @grep -nE '\<free \(\('                                         \
> > +       $(srcdir)/{lib,src}/*.[chly] /dev/null 2>/dev/null &&       \
> 
> How about if we use 'shopt -s nullglob' instead?  That way, we don't
> have to have the '2>/dev/null', and we catch a problem if a file is
> unreadable (e.g., dangling symlink).  shopt isn't portable, but surely
> we can assume Bash here.

Good idea.

> We can do this systematically, even for files that don't glob now.

Yes, done.

> >  sc_changelog:
> > -   @grep -n '^[^12 ]' $$(find . -maxdepth 2 -name ChangeLog) &&    \
> > +   @sed '/^-----/,$$d' $$(find . -maxdepth 2 -name ChangeLog)      \
> 
> Shouldn't there be a /dev/null here too, in case there are no ChangeLog
> files at all?

As far as I know, ChangeLog files are mandatory.  According to
standards.texi, you can share one ChangeLog for a tree of
subdirectories, but it has to sit in the top directory.  So I
think it's not bad to enforce that.

I found more issues with imported files (standards.texi has trailing
spaces, for example; sorry for not catching this earlier), and I think
that it's not our job to keep those files clean, esp. as that could be
daunting.  Same thing with generated files: Automake's macros may
contain space-tab; also, expansion of innocent Autoconf macros may lead
to space-tab.

So let's add some exemptions.

I have already applied the second patch (which was reviewed already).
Unless there are objections to the first (adding the .x-* files and so
on), I will apply that tomorrow as well.  With the patch in place,
syntax-check passes.

Cheers,
Ralf

        * doc/autoconf.texi: Remove unused words from word list.
        * .x-sc_prohibit_atoi_atof, .x-sc_space_tab, .x-sc_sun_os_names,
        .x-sc_trailing_space: New files.

        * Makefile.maint (sc_cast_of_argument_to_free): Do not fail when
        no file matches the glob, discard the warning, set `nullglob'.
        (syntax-check): Likewise.
        (sc_cast_of_x_alloc_return_value): Likewise.
        (sc_cast_of_alloca_return_value, sc_error_exit_success)
        (sc_prohibit_jm_in_m4, .re-list, sc_unmarked_diagnostics)
        (m4-check): Likewise.
        (sc_system_h_headers): Do not print rule on execution.
        (sc_tight_scope): Do not fail for non-existing `src' directory.
        (sc_changelog): Skip the Copyright footer.
        * lib/autoconf/lang.m4: Remove trailing space.

x-files.diff
Description: Text document

maint.diff
Description: Text document