autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Remove the rest of the comment from _AC_CACHE_DUMP


From: Ralf Wildenhues
Subject: Re: Remove the rest of the comment from _AC_CACHE_DUMP
Date: Sat, 8 Apr 2006 11:02:44 +0200
User-agent: Mutt/1.5.9i

Hi Stepan,

Thank you for doing this research!

* Stepan Kasal wrote on Fri, Apr 07, 2006 at 09:31:13PM CEST:
> 
> on a second thought, I tried to dig out what are the roots of this comment:
> 
> > > # WARNING: Be sure not to use single quotes in there, as some shells,
> > > # such as our DU 5.0 friend, will then `close' the trap.
> 
> and it turned out that it is the change which can be displayed by
> 
> cvs di -r1.75{8,9} lib/autoconf/general.m4

which is:

| --- lib/autoconf/general.m4     27 Aug 2001 07:17:23 -0000      1.758
| +++ lib/autoconf/general.m4     28 Aug 2001 09:37:21 -0000      1.759
| @@ -1209,6 +1209,8 @@
|  # When interrupted or exit'd, cleanup temporary files, and complete
|  # config.log.  We remove comments because anyway the quotes in there
|  # would cause problems or look ugly.
| +# WARNING: Be sure not to use single quotes in there, as some shells,
| +# such as our DU 5.0 friend, will then `close' the trap.
|  trap 'exit_status=$?
|    # Save into config.log some information that might help in debugging.
|    {
| @@ -1223,7 +1225,7 @@
|      if test -s confdefs.h; then
|        AS_BOX([confdefs.h.])
|        echo
| -      sed '/^$/d' confdefs.h
| +      sed "/^$/d" confdefs.h
|        echo
|      fi
|      test "$ac_signal" != 0 &&


> The following patch is just a comment change, can we commit it now?

Reading the patch, I think the real reason why above failed was that in
   trap '...'/^$/d'...'

the shell in question interprets the `^' as introducing a pipe.
So yes, please apply.  You could also just delete the comment.

Cheers,
Ralf

> 2006-04-07  Stepan Kasal  <address@hidden>
> 
>       * lib/autoconf/general.m4 (_AC_INIT_PREPARE): Fix the wording
>       of the warning introduced by the 2001-08-28 change.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]