autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: testsuite buglet


From: Ralf Wildenhues
Subject: Re: testsuite buglet
Date: Sun, 9 Apr 2006 07:36:51 +0200
User-agent: Mutt/1.5.9i

Hi Eric,

* Eric Blake wrote on Sun, Apr 09, 2006 at 12:22:14AM CEST:
> I think this patch:
> http://lists.gnu.org/archive/html/autoconf-patches/2006-03/msg00067.html
> 
> was inadvertantly applied wrong (it put the test for $() on the `` tests, then
> calls out the $() tests in the changelog).

Indeed.  I'm pretty sure I tested the right tests back then, so I can
only guess that this was caused by `patch' choosing the wrong place to
apply.

I've installed this change; adjusting the ChangeLog entry a bit, and
throwing out the independent rest of your posted (and malformed BTW)
patch.

Cheers, and thanks for catching this!
Ralf

2006-04-09  Eric Blake  <address@hidden>

        * tests/autotest.at (Backquote command substitution),
        (Multiline backquote command substitution): Remove mistaken
        AT_NO_CMDSUBST from the 2006-03-14 patch, which was meant to be
        applied...
        (Parenthetical command substitution, Multiline parenthetical
        command substitution): here.

Index: tests/autotest.at
===================================================================
RCS file: /cvsroot/autoconf/autoconf/tests/autotest.at,v
retrieving revision 1.11
diff -u -r1.11 autotest.at
--- tests/autotest.at   5 Apr 2006 16:04:22 -0000       1.11
+++ tests/autotest.at   9 Apr 2006 05:36:00 -0000
@@ -110,8 +110,7 @@
 
 AT_CHECK_AT_TEST([Backquote command substition],
   [AT_CHECK([echo `echo hi`], 0, [hi
-], [])],
-  [AT_NO_CMDSUBST])
+], [])])
 
 
 AT_CHECK_AT_TEST([Multiline backquote command substition],
@@ -120,12 +119,12 @@
 ])
    AT_CHECK([echo "`cat myfile`"], 0, [foo
 bar
-], [])],
-  [AT_NO_CMDSUBST])
+], [])])
 
 AT_CHECK_AT_TEST([Parenthetical command substition],
   [AT_CHECK([echo $(echo hi)], 0, [hi
-], [])])
+], [])],
+  [AT_NO_CMDSUBST])
 
 AT_CHECK_AT_TEST([Multiline parenthetical command substition],
   [AT_DATA([myfile],[foo
@@ -133,7 +132,8 @@
 ])
    AT_CHECK([echo "$(cat myfile)"], 0, [foo
 bar
-], [])])
+], [])],
+  [AT_NO_CMDSUBST])
 
 
 ## ------------------------- ##




reply via email to

[Prev in Thread] Current Thread [Next in Thread]