Re: Avoid certain spurious `testsuite' rebuilds

[Stepan Kasal]

Hi,

On Mon, Apr 10, 2006 at 02:41:38PM +0200, Ralf Wildenhues wrote:
> > > Dangerous.  [...]
...
> > This change simplifies tests/Makefile.am, so I tend to like it.
> 
> This statement is a direct argument to skip this for 2.60: no
> simplifications now, only actual bug fixes.

sure.  You told me during one of our phone calls: ``it's not going in''.
I assumed it's settled and I never meant to question it.

> > And what about ``testsuite.new''?
> 
> That's better.

Will be in a future version of my patch; after 2.60.

> > > You forgot to adjust the part in the trap.
> > 
> > I thought that the trap code is OK (it is triggered by the `exit 1').
> > What have I missed.
> 
> The trap code touches several files.  Isn't that wrong for them to have
> new time stamps in the error case?

Yes, you are right.

(I also noted that the trap uses "for file ; do..." while all the rest
of the script uses "for file in $src; do"...)

Perhaps the following changes should go in right now?
1) mktests.sh no longer tolarates bugs
2) thus the trap doesn't touch the *.at files
3) "trap '' 0" might be more portable

Attaches please find a proposed patch, to be committed right now.

Stepan Kasal

autoconf-20060410-mktests.patch
Description: Text document