Re: Fix `make update'

[Paul Eggert]

Ralf Wildenhues <address@hidden> writes:

> -       grep 'enum { COPYRIGHT_YEAR = 2005 };' $(v_etc_file) \
> +       grep 'enum { COPYRIGHT_YEAR = 2006 };' $(v_etc_file) \

This should use "date +%Y" rather than hardwiring the year.
(There may be problems near 00:00 on January 1, but if that turns into
an issue, we can standardize on the time zone used in Cambridge,
Massachusetts.  :-)

> -     test "$$fail" && exit 1
> +     if test "$$fail"; then exit 1; else :; fi

That last line is confusing and should be just "exit $$status",
reworking the earlier code accordingly.  The code should probably also
check the status of the other CVS command in that loop.  Something
like this, perhaps:

cvs-update:
        status=0;                                                       \
        for f in $(cvs_files); do                                       \
          test -f $$f || { echo "*** skipping $$f" 1>&2; continue; };   \
          cvs diff $$f > /dev/null                                      \
            || { status=$$?;                                            \
                 echo "*** $$f is locally modified; skipping it" 1>&2;  \
                 continue; };                                           \
          file=$$(basename $$f);                                        \
          echo checking out $$file...;                                  \
          $(CVS) -d $(automake_repo) co -p automake/lib/$$file> $$f.t   \
            && $(move_if_change) $$f.t $$f || status=$$?;               \
        done;                                                           \
        exit $$status