[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Suggestion: AC_DEFINE -> m4_pattern_allow

From: Ralf Wildenhues
Subject: Re: Suggestion: AC_DEFINE -> m4_pattern_allow
Date: Mon, 22 May 2006 15:20:19 +0200
User-agent: Mutt/1.5.11

Hi Stepan, Akim,

* Stepan Kasal wrote on Mon, May 22, 2006 at 03:07:36PM CEST:
> On Fri, May 19, 2006 at 05:04:00PM +0200, Akim Demaille wrote:
> > I have this package at hand, say FooBar, which installs a prefixed
> > form of config.h.  Its own macros are, of course, named FB_*, which is
> > m4_pattern_forbidden.  But then I have to explicitly m4_pattern_allow
> > all my FB_PACKAGE_VERSION etc.
> > 
> > I suggest that the AC_DEFINE family explicitly allow its $1.
> this sounds good.  (Note that AC_SUBST already allows its parameter.)

Thanks for the note, it's persuasive: it's good to be consistent.

> Proposed patch attached.

Go ahead, but the patch is missing a short NEWS entry and a test.  ;-)
(I can add this if you have little time.)

>       * lib/autoconf/general.m4 (AC_DEFINE_TRACE_LITERAL): Pass
>       the parameter to m4_pattern_allow.

Cheers, and thanks!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]