Re: Spurious datarootdir warnings in Wine configure

[Stepan Kasal]

Hello Ralf,


I have read the patch.  Looks good, few nits below.

> OK to apply and start the `Release Procedure'?  :-)

Yes.

On Thu, Jun 22, 2006 at 08:03:08PM +0200, Ralf Wildenhues wrote:
> address@hidden
> +AC_DEFUN([AC_DATAROOTDIR_CHECKED])
> address@hidden example
> +
> address@hidden
> +to your @file{configure.ac} to disable the warnings.  Note that for your own
> +macros, you should use a different prefix (@pxref{Macro Names}).

I'd say something like:
(Note that this is an exception to the rule that you should not
define macros starting with @code(AC_} (@pxref{Macro Names}).

> -$ac_datarootdir_hack
> +m4_ifndef([AC_DATAROOTDIR_CHECKED], [$ac_datarootdir_hack])

Perhaps:

m4_ifndef([AC_DATAROOTDIR_CHECKED], [$ac_datarootdir_hack
])dnl

to avoid the empty line in the sed script?  (Just a cosmetic change.)

> +d@&address@hidden # The following line silences the warnings, if uncommented:
> +d@&address@hidden AC_DEFUN([AC_DATAROOTDIR_CHECKED])
...
> +sed 's/d@&address@hidden //' configure.ac >t

I would do:

d@&address@hidden The following line silences the warnings, if uncommented:
d@&address@hidden AC_DEFUN([AC_DATAROOTDIR_CHECKED])
...
sed '/AC_DEFUN/s/^d@&address@hidden //' configure.ac >t

to educate potential reader that if the macro doesn't produce any
text, then the comment shouldn't go to the expansion either.

Enjoy the procedures!
        Stepan