[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: doc patches for shell file descriptors, OSF, etc.

From: Ralf Wildenhues
Subject: Re: doc patches for shell file descriptors, OSF, etc.
Date: Thu, 6 Jul 2006 20:13:03 +0200
User-agent: Mutt/1.5.11+cvs20060403

* Paul Eggert wrote on Wed, Jun 28, 2006 at 07:50:40PM CEST:
> This change was prompted by
> <>,
> but I cleaned up some of the HP-UX / OSF/1 discussion while I was in
> the neighborhood.

I have scanned Automake and Libtool for instances of this bug, and
installed the patch below for Automake to follow the style guideline,
even if it won't fix a bug in this case:

- Really the issue that the redirection of stdout is mentioned in the
  shell trace on stderr, does in fact happen with many shells, e.g.,
  ksh, pdksh.
- theoretically, the change below could fix a failure of
  tests/location.test, but:
- these shells also typically reset the 'x' flag upon shell function
  entry.  The change is still useful to avoid the bug when code is
  copied elsewhere, and for consistency.  Thus I have applied it.


        * tests/ (AUTOMAKE_run): Redirect stdout before stderr,
        for consistency with the recommendation prompted by this report:

Index: tests/
RCS file: /cvs/automake/automake/tests/,v
retrieving revision 1.38
diff -u -r1.38
--- tests/       10 May 2006 21:14:36 -0000      1.38
+++ tests/       5 Jul 2006 21:44:35 -0000
@@ -331,7 +331,7 @@
-  $AUTOMAKE ${1+"$@"} 2>stderr >stdout || exitcode=$?
+  $AUTOMAKE ${1+"$@"} >stdout 2>stderr || exitcode=$?
   cat stderr
   cat stdout
   test $exitcode = $expected_exitcode || exit 1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]