[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch from coreutils/gnulib for AC_FUNC_GETMNTENT

From: Stepan Kasal
Subject: Re: patch from coreutils/gnulib for AC_FUNC_GETMNTENT
Date: Fri, 15 Sep 2006 17:03:48 +0200
User-agent: Mutt/

  as promised, I committed the patch from the attached mail.
--- Begin Message --- Subject: Re: patch from coreutils/gnulib for AC_FUNC_GETMNTENT Date: Mon, 22 May 2006 11:54:59 +0200 User-agent: Mutt/

regarding the following patch:

On Sun, May 21, 2006 at 09:46:34PM -0700, Paul Eggert wrote:
>       2006-01-13  Jim Meyering  <address@hidden>
>       Invoke AC_CHECK_FUNCS(getmntent) unconditionally so that tests of
>       $ac_cv_func_getmntent (e.g., in gl_LIST_MOUNTED_FILE_SYSTEMS) need
>       not double-quote uses of that variable, to accommodate the rare
>       case in which getmntent is available in none of the libraries
>       checked.  This happens at least on FreeBSD 5.0.
> --- functions.m4.~1.100.~     2006-05-18 15:37:22.000000000 -0700
> +++ functions.m4      2006-05-21 21:41:06.000000000 -0700
> @@ -799,7 +799,8 @@ AN_FUNCTION([getmntent], [AC_FUNC_GETMNT
>  [# getmntent is in the standard C library on UNICOS, in -lsun on Irix 4,
>  # -lseq on Dynix/PTX, -lgen on Unixware.
> -AC_SEARCH_LIBS(getmntent, [sun seq gen], [AC_CHECK_FUNCS(getmntent)])
> +AC_SEARCH_LIBS(getmntent, [sun seq gen])
> +AC_CHECK_FUNCS(getmntent)
>  ])

If I understand it correctly, the AC_CHECK_FUNCS macro is redundant,
so we can eliminate it.
We have to set ac_cv_func_getmntent and HAVE_GETMNTENT, for
compatibility reasons, but we eliminate one compilation.

If there are no objections, I'll install the following patch a few weeks
after the 2.60 release, when all the guys from TIME and CNN will allow
Ralf to get some sleep again.

Have a nice day,

Attachment: autoconf-20060522-getmntent.patch
Description: Text document

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]