[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix chdir-long.m4 caching

From: Eric Blake
Subject: Re: Fix chdir-long.m4 caching
Date: Tue, 26 Sep 2006 06:09:51 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20060909 Thunderbird/ Mnenhy/

Hash: SHA1

Hi Ralf,

According to Ralf Wildenhues on 9/25/2006 11:00 PM:
>> How about covering our tracks so this won't happen again?
> Nice idea (I had it too but wasn't sure whether it could be done safely).
> Your patch has the logic the other way round, and it fails to work with
> shell indirections.

Indeed - I was just throwing the idea out for comment, and had not tested
it yet (or I probably would have noticed my backwards logic).

> I'm still not sure whether the following is safe.

It looks right to me - all it does is add a warning if the first argument
is literal but does not contain _cv_; otherwise it does not change
behavior.  I say go for the patch, as you have it written; and after we
figure out a test case to add to make sure we are triggering the warning
as expected.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]