|
From: | Stepan Kasal |
Subject: | Re: [GNU Autoconf 2.60] testsuite: 3 120 failed |
Date: | Mon, 9 Oct 2006 17:52:51 +0200 |
User-agent: | Mutt/1.4.2.1i |
Hello, On Fri, Oct 06, 2006 at 05:49:04PM +0200, Stepan Kasal wrote: > I will break the patch into the ``individual parts'' and add my > comments tomorrow. I apologize I'm late. Paul's patch contained 4 changes: 1) Do not play with /usr/bin/posix nor BIN_SH. This was the main part of the patch; I slightly modified the comment above _AS_DETECT_BETTER_SHELL, see autoconf-20061009-bin-sh-1.patch, attached. Ralf has approved the idea, so I guess I can commit this, unless a mistake is found. 2) Set DUALCASE in AS_SHELL_SANITIZE instead of AS_BOURNE_COMPATIBLE. This was discussed in http://lists.gnu.org/archive/html/autoconf-patches/2006-04/msg00128.html Updated version of the proposal is attached here as autoconf-20061009-bin-sh-2.patch , to be applied after patch 1). OK to commit? 3) AS_EXECUTABLE_P is reduced to `test -x' (on modern hosts). (See the attached autoconf-20061009-bin-sh-3.patch.) IIRC, the current implementation of AS_EXECUTABLE_P is a result of a long discussion. In particular, mere `test -x' was refused because it is true for a directory, and one might encounter a directory named `perl' somewhere in PATH. I think it is best to keep the current implementation. 4) Use AS_EXECUTABLE_P in _AS_DETECT_BETTER_SHELL. (See autoconf-20061009-bin-sh-4.patch, also attached.) This depends on 3) and introduces problems reported by Ralf. To sum up: I suggest to accept 1), 2) and reject 3), 4). Comments welcome. Stepan kasal
autoconf-20061009-bin-sh-1.patch
Description: Text document
autoconf-20061009-bin-sh-2.patch
Description: Text document
autoconf-20061009-bin-sh-3.patch
Description: Text document
autoconf-20061009-bin-sh-4.patch
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |