[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: install-sh misbehaves badly on buggy FreeBSD systems

From: Stepan Kasal
Subject: Re: install-sh misbehaves badly on buggy FreeBSD systems
Date: Tue, 10 Oct 2006 11:08:27 +0200
User-agent: Mutt/

Hello Paul,

is there an implementation of mkdir which understands `-p' and `--' but
does not understand `-m'?

If such an implementation existed, it could cause problems with your
new code:  The call
        $mkdirprog -m $different_mode -p -- "$tmpdir"
might create directories ./-m and ./$different_mode .

A possible fix is to skip the check for -m bugs if the first
mkdir call did not contain `-m'.

Attached please find a variation of your patch.  Do you like this

I'm using `test -z "$mkdir_mode"' because $mkdir_mode may not be a
binary operator, so -z is safe here.
Moreover, I removed the `X' from the last test call, because it is
more readable this way and we know that the ls_ld_tmpdir* variables
start with `d'.

Have a nice day,
        Stepan Kasal

Attachment: automake-20061010-install-d.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]