[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix AT_SETUP's sh-escaping

From: Joel E. Denny
Subject: Re: fix AT_SETUP's sh-escaping
Date: Thu, 26 Oct 2006 14:28:07 -0400 (EDT)

On Thu, 26 Oct 2006, Stepan Kasal wrote:

> Run the following
>       tests/testsuite -l|grep ","
> to see the problem.
> The fix is to do
> at_help_all="AS_ESCAPE(m4_defn([AT_help_all]))"


> they escape before
> expanding the test description.

Ok, this seemingly obvious point didn't click with me completely 
yesterday.  It seems a little funny to me that anyone would (1) pass in a 
test description with macros to be expanded later and then (2) expect that 
nothing strange would happen if the expansions contained characters that 
are special to whatever the output language happens to be.  The user 
should expand the macros up front instead, and that should always do what 
he wants.  However, I suppose that's not a user-friendly view as it's the 
kind of mistake I would likely make.  Am I getting it now?

I suppose I should add a test case with a macro that needs escaping after 
expansion.  Expected failure for now.

> You should also check that
>    AT_SETUP([[macro_name]])
> really leaves `macro_name' unexpanded.
> In other words, with this
> m4_define([macro_name], [[macro_expanded]])
> m4_define([macro_expanded], [macro_overexpanded])
> ...
> AT_SETUP([macro_name])
> you should get `macro_expanded' on the output.

I'll do all this later today hopefully.  Thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]