[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix AT_SETUP's sh-escaping

From: Paul Eggert
Subject: Re: fix AT_SETUP's sh-escaping
Date: Fri, 17 Nov 2006 01:20:03 -0800
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Ralf Wildenhues <address@hidden> writes:

> - some Solaris expr have a serious length limitation (see
>   autoconf.texi); even if it's not likely to be early in $PATH, it
>   should probably not be used unconditionally.

That shouldn't be a problem, as Solaris has printf.

> - Libtool checks printf with long strings because some (presumably older
>   Solaris?  I haven't tested at all) have problems with long arguments
>   as well,

How long?  If it's reeeeally long I'm not particularly worried.
(They probably had problems with echo, too.  :-)

> - Some uses now forbid to use both " and ' in arguments.  I dunno, but
>     ERL='erl -Dfoo="quoted"'
>   at least seems imaginable to me.  With $ac_[]_AC_LANG_ABBREV[]_v_output
>   this looks like a no-go to me, even more so the line
>       AS_ECHO(["$ac_var='\''$ac_val'\''"])

Sorry, I don't follow this one.  Here's the change:

-      echo "$ac_var='\''$ac_val'\''"
+      AS_ECHO(["$ac_var='\''$ac_val'\''"])

If the quotes are harmful after the change, they'll have the same
harm before, so there's no regression here.

> - some use cases may cause expr to match a user-passed empty string,
>   resulting in 0 on output (that is at least how I interpret the
>   statement about QNX 4.25 native expr).

But surely QNX 4.25 has printf, so it's OK.

> - \n is not interpreted correctly by Solaris 8 /usr/ucb/tr,

Yes, I will fix that to use an actual newline rather than backslash-n.

> - this patches touches a lot of internal code, lots of which is used in
>   many places.  It would need thorough testing.
> Esp. wrt. the last point (I'm thinking back of the _AC_DO* changes close
> before 2.60, and the hassle that caused because of underquotation in
> users', I wonder whether it would be a good idea to
> postpone this patch to after 2.61,


> and just comment out the 'Macro with
> backslash in a test title' test for now (as it neither fails nor passes
> reliably).

Sounds good.  I installed the following.  I'd like to put out 2.61
fairly soon (ideally today :-).

2006-11-17  Paul Eggert  <address@hidden>

        * tests/ (Macro with backslash in a test title):
        Comment out for now, as this tests neither fails nor passes
        reliably.  Problem reported by Ralf Wildenhues.

--- tests/   9 Nov 2006 05:59:01 -0000       1.19
+++ tests/   17 Nov 2006 09:17:19 -0000
@@ -291,8 +291,9 @@
 AT_CHECK_AT_TITLE_CHAR([Macro with single-quote], [macro_single_quote], ['])
 AT_CHECK_AT_TITLE_CHAR([Macro with double-quote], [macro_double_quote],
                                                                    ["], [:])
-AT_CHECK_AT_TITLE_CHAR([Macro with backslash],       [macro_backslash],
-                                                                  [\\], [:])
+# This test neither fails nor passes reliably.
+# AT_CHECK_AT_TITLE_CHAR([Macro with backslash],       [macro_backslash],
+#                                                                  [\\], [:])

 ## ----------------- ##

reply via email to

[Prev in Thread] Current Thread [Next in Thread]