[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Stepan Kasal
Subject: Re: Prefer AM_CPPFLAGS to @CPPFLAGS@
Date: Tue, 21 Aug 2007 22:44:10 +0200
User-agent: Mutt/

Hello Ralf and Eric,

I like the patch provided by Ralf.
(I see I protested in June, but that was silly; sorry.)

I would change wording:
use Automake -> are using Automake

Moreover, in the example below, I would change:
datadir.h -> myprog-paths.h

I think this is closer to practice.  For example, gnumeric uses
gnumeric-paths.h for this purpose.  If there are more dirs to be
passed to the program, having separate .h files seems weird.

Together, it would form the patch attached here.

But if you decide to reject one or both of the above nits, feel free
to commit anyway.

A note:

The current form of my bad feelings of this part of documentation is:
The nodes "Defining Directories" and "Installation Directory
Variables" should be reorganized.  Perhaps the common info that make
should eval the variables should go to a separate node, referred from
both.  The node "Installation Directory Variables" looks weird: long
list, short explanation, another list of advices; it should be
I'd say that each node should contain either a long list or an
explanation of something.  At most, and exlpanation followed by a
related list.

Anyway, I don't think I'll be able to implement the above ideas
anytime soon, so it's wise to commit what we have.  I don't mean to
block it.

Have a nice day,

Attachment: autoconf-20070821-doc-am_cppflags.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]