autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Please normalize command line paths


From: Eric Blake
Subject: Re: Please normalize command line paths
Date: Fri, 05 Oct 2007 15:16:22 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paul Eggert on 10/5/2007 2:53 PM:
>> +  case $ac_val in
>> +    / | // ) ;;
>> +    */ ) eval $ac_var='`echo "$ac_val" | sed "s|/*\$||"`' ;;
>> +  esac
> 
> This mishandles ///, no?

For --prefix and --exec-prefix, no (the empty prefix is the kosher way to
have all other directories installed in the root directory).  But for
- --bindir and friends, you are correct.

>  Also, 'expr' is more reliable in the
> presence of weird characters, such as backslashes.  I installed this:
> 
> 2007-10-05  Paul Eggert  <address@hidden>
> 
>       * lib/autoconf/general.m4 (_AC_INIT_PARSE_ARGS): Handle "///"
>       correctly.

Thanks.  But should we be using $as_expr, with a sed fallback, as in
AS_BASENAME?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHBqmm84KuGfSFAYARAo/0AJ9UPWOS9Gc79Hhq/plfSIUiGzMJigCggWIh
XevcAAvX2/M9knez5CvwCF4=
=S9C4
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]