autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Handling of single-quoted comma [was: m4_defn overhead]


From: Ralf Wildenhues
Subject: Re: Handling of single-quoted comma [was: m4_defn overhead]
Date: Tue, 16 Oct 2007 07:33:19 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

Hello Eric,

Wow.

There is only one tiny nit I can find to pick (and I tried hard ;-)

* Eric Blake wrote on Mon, Oct 15, 2007 at 09:12:52PM CEST:
> --- a/doc/autoconf.texi
> +++ b/doc/autoconf.texi
> @@ -10696,6 +10696,32 @@ Conveniently, if there is just one @var{arg}, this 
> effectively adds a
>  level of quoting.
>  @end defmac
>  
> address@hidden m4_expand (@var{arg})
> address@hidden
> +Return the expansion of @var{arg} as a quoted string.  Whereas
> address@hidden is designed to collect expanded text into a single
> +argument, @code{m4_expand} is designed to perform one level of expansion
> +on quoted text.  The distinction is in the treatment of whitespace
> +following a comma in the original @var{arg}.  Any time multiple
> +arguments are collected into one with @code{m4_quote}, the M4 argument
> +collection rules discard the whitespace.  But with @code{m4_quote},
> +whitespace is discarded only if it results from unquoted commas in the
> +expansion of macros contained in @var{arg}.

The last sentence makes me stumble a bit.  Did you mean "But with
@code{m4_expand}"?  In case you didn't, then the "But" makes little
sense, as the previous sentence dealt with m4_quote, too.  In case
you did, which I believe, a minor style nit that "but" is best not put
at the beginning of a sentence ("... whitespace, but ...") or replaced
by "However,".

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]