Re: Autotest function usage

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Ralf Wildenhues on 10/17/2007 12:34 PM:
> 
> With these patches, and CONFIG_SHELL=/bin/zsh, the testsuite only fails
> `Configuring subdirectories', because `configure --silent' still outputs
> the warnings about broken shell function support.  I don't mind this
> failure (one could think about outputting on stderr).  Of course, that
> doesn't mean that all tests work correctly now.  ;-)

Hmm, that sounds like a separate patch for directing shell function
warnings to stderr, but sounds like the way to go.

> 
> OK to apply these two patches?
> 
> Cheers,
> Ralf
> ---
> 
>     * lib/autotest/general.m4 (at_func_test): Fix test extraction script.
> 
> diff --git a/lib/autotest/general.m4 b/lib/autotest/general.m4
> index ce8abc8..52fa8ef 100644
> --- a/lib/autotest/general.m4
> +++ b/lib/autotest/general.m4
> @@ -295,7 +295,7 @@ at_func_diff_devnull ()
>  # then invoke it.
>  at_func_test ()
>  {
> -  if sed -n 
> '/address@hidden:@AT_START_'$[1]$'/,/address@hidden:@AT_STOP_'$[1]$'/p' 
> "$at_myself" \
> +  if sed -n 
> '/address@hidden:@AT_START_'$[1]'$/,/address@hidden:@AT_STOP_'$[1]'$/p' 
> "$at_myself" \

Wow.  What a typo.  And $'foo' is undefined among shells.  Yes, please
install this fix.

> 
>     Autotest: do not use shell functions for individual tests.
> 
>     * lib/autotest/general.m4 (AT_INIT) <at_func_test>: Merely
>     extract the source test source, do not invoke it.
>     (AT_SETUP, AT_CLEANUP): Source test code outside shell function.
>     * tests/autotest.at (Fallacy): Actually let the inner suite fail,
>     expect exit status of 1.
>     * tests/autotest.at (Skip): New test, for bogus zsh exit status.

Looks okay to me.  Please apply.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHFl1W84KuGfSFAYARAuRkAKDBn80PLasqCTtfKoP0ovBUH8U+hQCfXsa7
p86+LRxbXP8dwKW+6SQd0OQ=
=4MEI
-----END PGP SIGNATURE-----