[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/10] Proper file name escaping in Autoconf programs and Perl

From: Eric Blake
Subject: Re: [PATCH 1/10] Proper file name escaping in Autoconf programs and Perl modules.
Date: Wed, 05 Dec 2007 06:23:03 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20071031 Thunderbird/ Mnenhy/

Hash: SHA1

According to Ralf Wildenhues on 12/4/2007 2:45 PM:
> +AT_SETUP([autom4te and whitespace in file names])
> +
> +file='>file with  funny \ '\'' \'\'' $ & #!*? name'
> +dir='>dir with  funny \ '\'' \'\'' $ & #!*? name'

I'm wondering if it is worth splitting this one test into two, in order to
get more coverage on Windows ports - one that tests file names that can be
created by default on any windows platform, and one that covers the
remaining characters that can only be created in a cygwin managed mount.
In other words, ', $, &, #, !, and whitespace are safe, but \, " (did you
miss that on purpose?), <, >, *, and ? are not.

> +# skip if we cannot create such a file or directory
> +AT_CHECK([mkdir "$dir" "$cachedir" "$TMPDIR" && test -f "$file.m4" || exit 
> 77])

Unrelated to your patch series, but I'm wondering if we should provide
AT_SKIP or AT_SKIP_IF that uses the file system to record skips, so that
you can expand such a macro regardless of how many subshells you are
nested in, and not have to worry about exit status 77 propagating all the
way out to the test engine.  On the other hand, I know the tar testsuite
already defines its own AT_SKIP.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]