[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/10] Proper file name escaping in Autoconf programs and Perl

From: Ralf Wildenhues
Subject: Re: [PATCH 1/10] Proper file name escaping in Autoconf programs and Perl modules.
Date: Thu, 13 Dec 2007 11:14:22 +0100
User-agent: Mutt/1.5.17 (2007-11-13)

Hi Eric,

* Eric Blake wrote on Wed, Dec 12, 2007 at 11:55:43PM CET:
> Ralf Wildenhues <Ralf.Wildenhues <at>> writes:
> > +# the first one omits special characters that are not w32 safe.
> > +for funny in \
> > +  'with  funny '\'' $x & #! name ' \
> w32 also strips trailing spaces; usually not a problem when creating files 
> (since subsequent attempts to use the space also get stripped), but fatal 
> when 'mkdir "dir /"' silently creates "dir/", but you are still attempting to 
> reference "dir /sub" (you'd think that if w32 was going to silently strip 
> spaces, they could at least do it before directory separators as well, but 
> no).

Thanks, I didn't know that.

> > +  TMPDIR=" tmp$dir"
> > +  export TMPDIR
> > +
> > +  cat >"$file.m4" <<'END'
> This also caused a failure.  On cygwin, bash is using my patch to prefer 
> $TMPDIR rather than /tmp for creating here-docs, so you are using $TMPDIR set 
> to a non-existent directory.

Ah, yes, I should have known that.

> [Note to self: fix the cygwin port of bash to fall back on /tmp if
> $TMPDIR doesn't exist.]

Well, it may be helpful for the user to know that he's filling /tmp just
because he put a typo in TMPDIR.  FWIW, I don't think Posix specifies
what should happen in this case.

Thanks for cleaning up after me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]