[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/10] Whitespace robustness patch series

From: Benoit Sigoure
Subject: Re: [PATCH 0/10] Whitespace robustness patch series
Date: Sun, 16 Dec 2007 14:19:36 +0100

I'm trying to catch up on the ~90 autoconf ~60 automake and ~50 libtool mails standing in my mbox...

On Dec 4, 2007, at 10:39 PM, Ralf Wildenhues wrote:

Hello autoconf-patches,

- There is too much dwimmery going on in perl.  I think it needs more
than one quoting function; one for xsystem, and one for stuff like
    ... = new Autom4te::XFile "> $file"

but I wouldn't know how to make it foolproof.  First, if the space is
missing after `>' and $file begins with `>', then append mode is used.
But also, if $file begins with whitespace, that is just ignored anyway.
Not sure whether we want to protect the user from all such kinds of

I *guess* that Autom4te::XFile will then use either the builtin `open' or `IO::File'. Both of them can be called with the mode specified in a separate argument, which is safer:
  new IO::File "file", "r";

This solves the problem nicely and safely.

I'm going to read the patch series now :)

Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory

reply via email to

[Prev in Thread] Current Thread [Next in Thread]