[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: a couple of bugs
From: |
Eric Blake |
Subject: |
Re: a couple of bugs |
Date: |
Mon, 17 Dec 2007 06:03:22 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Benoit Sigoure on 12/17/2007 1:04 AM:
>
> ./torture.at:241: ./config.status --file=-:input </dev/null >/dev/full
> stderr:
> /tmp/autoconf/tests/testsuite.dir/at-test-source: line 893: /dev/full:
> Operation not supported
>
> This looks like a tpyo but I checked in the source and it's not, why not
> use something like /nonexistent/whatever?
There's a different between a shell failure in being able to create the
file (the tool under test isn't even run, because the shell errored out
beforehand), and a write file when writing to an existing device that runs
out of space. We really do want the latter, not the former. So the
correct fix is to first check whether /dev/full exists and is writable,
and if not, skip the test, before proceeding on with the attempt to
redirect tool output into the full device. Coreutils and m4 head both
have tests along those lines, which can be used as an example.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHZnOZ84KuGfSFAYARAtP+AKC8vGyfptmZH7IO+76iDICvPMGJlQCgoyd1
2WyEmvxAp5RA7ykYhaAwMlg=
=tMxV
-----END PGP SIGNATURE-----